Repository navigation
docs(upstream-sync): close the post-1.5.0 range at v0.46.1 - #225
Merged
Merged
Conversation
The explore budget epic shipped, so nothing from the 104-commit unreleased range is left unported. The entry's table, the header, and the title move to six tiers through v0.46.1, and the "still open" section becomes a closeout. It keeps the finding that explains why that port took eight review rounds: the whole-file rule returns a complete section before any budget or focus logic runs, and its line and character thresholds are independent, so a named symbol could vanish by two unrelated routes — one of which no clustering-path fix can reach. Both produced the same empty 615-byte answer, which is why the port needed two separate regression tests rather than one.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 141 141
Lines 78711 78711
=======================================
Hits 75052 75052
Misses 3659 3659 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final ledger entry for the post-
v1.5.0sync. Theexplorebudget epic shipped asv0.46.1, so nothing from the 104-commit unreleased range is left unported.Changes
v0.46.1(fix(explore): render the symbol you asked for, and charge what you spend #223, CG-38/36/30/28/26/31).v0.46.0to six tiers throughv0.46.1, and the title now reads TRIAGED and CLOSED.The finding it preserves
Recorded because it explains why that port needed eight review rounds, and because the next person to touch explore budgeting will otherwise re-derive it:
engine.rs's whole-file rule returns a complete section before any budget or focus logic exists, and its line and character thresholds are independent. So a named symbol could vanish by two unrelated routes — a file passing both gates has its section built and then rejected whole, where no clustering-path fix can reach it; a file passing the line gate but failing the character gate falls through to clustering and is rejected there. Both produced the same 615 bytes with zero sections that CG-38 exists to prevent, which is why the port needed two separate regression tests rather than one.CG-27 remains recorded as measured-and-rejected by upstream, and is not ported. The 26 DEFER items and the permanently-N/A
0682137are unchanged.Docs only: one file,
oxfmtidempotent, tracked parity unchanged at1.5.0— none of these releases ports an upstream release range, and upstream's newest tag is stillv1.5.0.